Skip to content

Conversation

@ChoiByungWook
Copy link
Contributor

@ChoiByungWook ChoiByungWook commented Apr 25, 2018

Issue #, if available:

Description of changes:
Add issue template asking for background information and a minimal repo, in order to help customers in a quicker fashion.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Apr 25, 2018

Codecov Report

Merging #162 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #162   +/-   ##
=======================================
  Coverage   90.63%   90.63%           
=======================================
  Files          37       37           
  Lines        2478     2478           
=======================================
  Hits         2246     2246           
  Misses        232      232

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d73c42...3630c5a. Read the comment docs.

Copy link
Contributor

@winstonaws winstonaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting this!

Please fill out the form below for any bugs.

### System Information
- **Framework**:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not every customer will be using a Framework - some could use 1P or BYO.


### System Information
- **Framework**:
- **Framework Version**:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add short instructions on how to find out the versions?

- **Framework**:
- **Framework Version**:
- **Python SDK Version**:
- **Are you using a custom container/image**:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just image is fine, you don't need container/image.

- **Framework Version**:
- **Python SDK Version**:
- **Are you using a custom container/image**:
- **Exact command to reproduce**:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this redundant with the Minimal repo section?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved the command to the bottom, but I think it is still necessary that the minimal repo case should be easy to run.

Describe the problem or feature request clearly here.

### Minimal repo / logs
Please provide any logs and a bare minimum reproducible test case, as this will be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should state that we need both the estimator/predictor code as well as the user scripts.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't agree with this statement, the minimal repo case isn't always going to need all of this.

@@ -0,0 +1,14 @@
Please fill out the form below for any bugs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "for reporting bugs or requesting debugging help"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it should just be, "Please fill out the form below."

Please fill out the form below.

### System Information
- **Framework(e.g. TensorFlow) / Algorithm(e.g. KMeans)**:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add space between word and (

winstonaws
winstonaws previously approved these changes Apr 26, 2018
@ChoiByungWook ChoiByungWook merged commit 0f594b1 into aws:master Apr 26, 2018
@ChoiByungWook ChoiByungWook deleted the issue_template branch December 1, 2020 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants