Skip to content

Conversation

@winstonaws
Copy link
Contributor

@winstonaws winstonaws commented Apr 16, 2018

Previously, our RTD builds were failing due to scipy/numpy dependencies declared in install_requires: https://readthedocs.org/projects/sagemaker/builds/7040261/

With this change, we now use conda for the RTD build environment, which allows us to install the dependencies.

Successful RTD build after changes:
https://readthedocs.org/projects/sagemaker/builds/7050841/

Docs after the changes:
http://sagemaker.readthedocs.io/en/rtd_debug/estimators.html

Based the changes off this issue: readthedocs/readthedocs.org#2549

And this repo, which the issue cites as an example: https://github.com/astropy/astropy

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Apr 16, 2018

Codecov Report

Merging #150 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #150   +/-   ##
=======================================
  Coverage   90.48%   90.48%           
=======================================
  Files          36       36           
  Lines        2438     2438           
=======================================
  Hits         2206     2206           
  Misses        232      232

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6ec6e4...2967ebb. Read the comment docs.

Copy link
Contributor

@ChoiByungWook ChoiByungWook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@ChoiByungWook ChoiByungWook merged commit 04bfc38 into master Apr 16, 2018
@winstonaws winstonaws deleted the rtd_debug branch April 16, 2018 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants