Skip to content

Conversation

@knakad
Copy link
Contributor

@knakad knakad commented Jan 13, 2020

Description of changes: Flagged re:Invent tests for quick canary. Selected one of each major piece of functionality.

  • Debugger: tests/integ/test_debugger.py::test_mxnet_with_all_rules_and_configs => Reasoning: Exercises all variants in a single test.
  • Monitoring: tests/integ/test_model_monitor.py::test_default_monitor_suggest_baseline_and_create_monitoring_schedule_with_customizations => Reasoning: These tests are quite slow, so I only want one of them in the quick canary. Given that choice, this is the best test, as it tests the most common use-case (default monitor) with all customizations.
  • Processing: Added test_sklearn_with_customizations + test_script_processor + test_processor. => Reasoning: One of each main use-case.
  • AutoPilot: One for auto_ml.fit, one for auto_ml.deploy. Reasoning: One of each main use-case.
  • Eureka: Added one of the tests. The others were specific use-cases and more specific tests (pagination, etc..).

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I used the commit message format described in CONTRIBUTING
  • I have used the regional endpoint when creating S3 and/or STS clients (if appropriate)
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@knakad knakad merged commit 95014ba into aws:master Jan 13, 2020
@knakad knakad deleted the origin-20190113-quick-canary-reinvet-2019 branch January 13, 2020 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants