Skip to content

Conversation

@nadiaya
Copy link
Contributor

@nadiaya nadiaya commented Nov 21, 2019

Final step in safely removing local mode dependencies from the list of required dependencies.

Related PRs: #1130 #1128

Issue: #1118

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I used the commit message format described in CONTRIBUTING
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@nadiaya nadiaya changed the title feature: remove local mode dependencies from required. feature: remove local mode dependencies from the list of required dependencies.. Nov 21, 2019
@nadiaya nadiaya changed the title feature: remove local mode dependencies from the list of required dependencies.. feature: remove local mode dependencies from the list of required dependencies. Nov 21, 2019
@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@nadiaya nadiaya requested a review from laurenyu November 21, 2019 19:43
@nadiaya nadiaya merged commit 987b364 into aws:master Nov 21, 2019
@nadiaya nadiaya deleted the local-dependencies branch November 21, 2019 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants