Skip to content

change: remove hardcoded creds from integ test #1030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2019
Merged

change: remove hardcoded creds from integ test #1030

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/integ/test_git.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,8 @@ def test_git_support_with_pytorch(sagemaker_local_session):


@pytest.mark.local_mode
@pytest.mark.skip("needs a secure authentication approach")
def test_git_support_with_mxnet(sagemaker_local_session):

script_path = "mnist.py"
data_path = os.path.join(DATA_DIR, "mxnet_mnist")
git_config = {
Expand All @@ -94,7 +94,7 @@ def test_git_support_with_mxnet(sagemaker_local_session):
"commit": PRIVATE_COMMIT,
"2FA_enabled": False,
"username": "git-support-test",
"password": "passw0rd@ %",
"password": "", # TODO: find a more secure approach
}
source_dir = "mxnet"
dependencies = ["foo/bar.py"]
Expand Down