Skip to content

change: remove hardcoded creds from integ test #1029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 6, 2019
Merged

change: remove hardcoded creds from integ test #1029

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d7769a6
change: remove hardcoded creds from integ test
laurenyu Sep 6, 2019
6faa162
Merge branch 'master' into remove-creds
laurenyu Sep 6, 2019
04df615
fix
laurenyu Sep 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/integ/test_git.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,14 +233,15 @@ def test_git_support_with_sklearn_ssh_passphrase_not_configured(


@pytest.mark.local_mode
@pytest.mark.skip("needs a secure authentication approach")
def test_git_support_codecommit_with_mxnet(sagemaker_local_session):
script_path = "mnist.py"
data_path = os.path.join(DATA_DIR, "mxnet_mnist")
git_config = {
"repo": CODECOMMIT_REPO,
"branch": CODECOMMIT_BRANCH,
"username": "GitTest-at-142577830533",
"password": "22LcZpWMtjpDG3fbOuHPooIoKoRxF36rQj7zdUvXooA=",
"password": "", # TODO: assume a role to get temporary credentials
}
source_dir = "mxnet"
dependencies = ["foo/bar.py"]
Expand Down