Skip to content

Use GitHub workflow for CI on PRs and master builds #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 7, 2022
Merged

Use GitHub workflow for CI on PRs and master builds #231

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dac1f03
Adding gh ci workflow
srprash Mar 3, 2022
502786a
changing branch to master to trigger workflow
srprash Mar 4, 2022
d178377
Update .github/workflows/ci.yml
srprash Mar 7, 2022
1618c92
Update .github/workflows/ci.yml
srprash Mar 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
name: Continuous Build

on:
push:
branches:
- master
pull_request:
branches:
- master

jobs:
build-test:
runs-on: windows-latest

env:
DOTNET_MULTILEVEL_LOOKUP: 1

strategy:
fail-fast: false
matrix:
version: [net452, netcoreapp2.0, netcoreapp3.1]
Copy link
Contributor

@jon-armen jon-armen Mar 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason we're targeting netcoreapp2.0 out of support? Why not target 2.1

Suggested change
version: [net452, netcoreapp2.0, netcoreapp3.1]
version: [net452, netcoreapp2.1, netcoreapp3.1]

Copy link
Contributor

@jon-armen jon-armen Mar 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind for now, I see that the test projects are currently referencing netcoreapp2.0. Much better to get CI up and running any make those changes in another pr.

Copy link
Collaborator Author

@srprash srprash Mar 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. We should update our targeted frameworks to the supported ones for the whole SDK some time soon.

Copy link
Contributor

@jon-armen jon-armen Mar 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got a PR out there to do just that. I'll update it once we have this merged.


steps:
- name: Checkout repository
uses: actions/checkout@v2

- uses: actions/setup-dotnet@v1
with:
dotnet-version: '2.0.x'

- uses: actions/setup-dotnet@v1
with:
dotnet-version: '3.1.x'

- name: Install dependencies
run: dotnet restore sdk/AWSXRayRecorder.sln

- name: Build solution
run: dotnet build sdk/AWSXRayRecorder.sln --configuration Release --no-restore

- name: Run tests
run: >-
dotnet test sdk/test/UnitTests/bin/Release/${{matrix.version}}/AWSXRayRecorder.UnitTests.dll
--configuration Release
--no-build
--logger "console;verbosity=detailed"