fix: ability to serialize GUIDs #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srprash
approved these changes
Jul 29, 2021
Collaborator
srprash
left a comment
srprash
left a comment
There was a problem hiding this comment.
Thanks for adding this. It is unfortunate that we maintain this internal copy of LitJSON since the actual library is still not stable (current version is 0.17.0). I think that the lLitJSON library itself would be running into this issue. In that case, it would be good to bring to their notice. I'll try it out and open an issue with them. :)
Contributor
|
@srprash Can we merge this? |
This was referenced Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #202
Added ability to serialize GUID.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.