Third party, Notice and updated Readme #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
reviewed
Jul 11, 2020
| @@ -1 +1,2 @@ | |||
| Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
| AWS X-Ray SDK .NET Agent | |||
| Copyright 2020 Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
Contributor
There was a problem hiding this comment.
Can you remove this file? It's not an open source license so doesn't belong here. We already have the open source license in LICENSE so don't need this file.
Contributor
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
I believe since NOTICE is auto-committed by Amazon open source, we should inquire with them before removing this file.
Contributor
Author
There was a problem hiding this comment.
I added this line AWS X-Ray SDK .NET Agent to the NOTICE, so I guess it's can be removed.
README.md
Outdated
| ## License | ||
|
|
||
| The AWS X-Ray SDK DotNet Agent is licensed under the Apache 2.0 License. See LICENSE and NOTICE.txt for more information. | ||
| The AWS X-Ray SDK DotNet Agent is licensed under the Apache 2.0 License. See LICENSE and NOTICE.txt for more information. |
Contributor
There was a problem hiding this comment.
Here too remove NOTICE reference
willarmiros
approved these changes
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIRD-PARTY, NOTICE and updated README.md
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.