Skip to content

Conversation

@ThirdEyeSqueegee
Copy link
Member

Issue #, if available:
#19

Description of changes:

  • Add optional versionId and versionStage args to GetSecretString and GetSecretBinary to allow retrieving secrets by version ID or version stage

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ThirdEyeSqueegee ThirdEyeSqueegee requested a review from a team as a code owner April 10, 2025 21:56
@codecov
Copy link

codecov bot commented Jul 14, 2025

Codecov Report

❌ Patch coverage is 72.41379% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.65%. Comparing base (db8a853) to head (36a08ac).

Files with missing lines Patch % Lines
.../secretsmanager/caching/cache/SecretCacheItem.java 52.94% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                 v2     #153      +/-   ##
============================================
- Coverage     90.86%   87.65%   -3.22%     
- Complexity       90       93       +3     
============================================
  Files             6        6              
  Lines           230      243      +13     
  Branches         24       29       +5     
============================================
+ Hits            209      213       +4     
- Misses           18       24       +6     
- Partials          3        6       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants