Add DownloadResponse mapping #4063
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GarrettBeatty
force-pushed
the
GarrettBeatty/stacked/5
branch
from
4b5b83a to
b28f801
Compare
This was referenced Oct 21, 2025
GarrettBeatty
changed the base branch from
GarrettBeatty/stacked/4
to
feature/transfermanager
GarrettBeatty
force-pushed
the
GarrettBeatty/stacked/5
branch
from
b28f801 to
a47780d
Compare
GarrettBeatty
changed the base branch from
feature/transfermanager
to
GarrettBeatty/stacked/4
GarrettBeatty
changed the base branch from
GarrettBeatty/stacked/4
to
feature/transfermanager
GarrettBeatty
force-pushed
the
GarrettBeatty/stacked/5
branch
from
a47780d to
5bd3140
Compare
GarrettBeatty
changed the base branch from
feature/transfermanager
to
GarrettBeatty/stacked/4
GarrettBeatty
changed the base branch from
GarrettBeatty/stacked/4
to
feature/transfermanager
GarrettBeatty
force-pushed
the
GarrettBeatty/stacked/5
branch
from
5bd3140 to
20772b5
Compare
GarrettBeatty
changed the base branch from
feature/transfermanager
to
GarrettBeatty/stacked/4
GarrettBeatty
changed the base branch from
GarrettBeatty/stacked/4
to
feature/transfermanager
GarrettBeatty
force-pushed
the
GarrettBeatty/stacked/5
branch
from
20772b5 to
7b4b267
Compare
GarrettBeatty
changed the base branch from
feature/transfermanager
to
GarrettBeatty/stacked/4
GarrettBeatty
changed the base branch from
GarrettBeatty/stacked/4
to
feature/transfermanager
GarrettBeatty
force-pushed
the
GarrettBeatty/stacked/5
branch
from
7b4b267 to
19dcad3
Compare
GarrettBeatty
changed the base branch from
feature/transfermanager
to
GarrettBeatty/stacked/4
GarrettBeatty
changed the base branch from
GarrettBeatty/stacked/4
to
feature/transfermanager
GarrettBeatty
force-pushed
the
GarrettBeatty/stacked/5
branch
from
19dcad3 to
44c48e2
Compare
GarrettBeatty
changed the base branch from
feature/transfermanager
to
GarrettBeatty/stacked/4
GarrettBeatty
changed the base branch from
GarrettBeatty/stacked/4
to
feature/transfermanager
GarrettBeatty
force-pushed
the
GarrettBeatty/stacked/5
branch
from
44c48e2 to
1fbd586
Compare
GarrettBeatty
changed the base branch from
feature/transfermanager
to
GarrettBeatty/stacked/4
GarrettBeatty
changed the base branch from
GarrettBeatty/stacked/4
to
feature/transfermanager
GarrettBeatty
force-pushed
the
GarrettBeatty/stacked/5
branch
from
1fbd586 to
79996ec
Compare
GarrettBeatty
commented
Oct 23, 2025
| response.ContentLanguage = S3Transforms.ToString(responseData.GetHeaderValue("Content-Language")); | ||
| if (responseData.IsHeaderPresent("Content-Length")) | ||
| response.Headers.ContentLength = long.Parse(responseData.GetHeaderValue("Content-Length"), CultureInfo.InvariantCulture); | ||
| response.Headers.ContentLanguage = S3Transforms.ToString(responseData.GetHeaderValue("Content-Language")); |
Contributor
Author
There was a problem hiding this comment.
Adds this to the header to make it easy for TransferUtilityDownloadResponse, since we just copy source.header to target.header
GarrettBeatty
commented
Oct 23, 2025
| // Resolve alias to actual property name | ||
| var resolvedPropertyName = ResolvePropertyName(propertyName, sourceType.Name); | ||
| var sourceProperty = sourceType.GetProperty(resolvedPropertyName); | ||
|
|
Contributor
Author
There was a problem hiding this comment.
added this change because of the issue with contentlanguage. previously we were only setting the property and not the value in the headers. this makes it so we set both the property and the headers value in the source object
GarrettBeatty
commented
Oct 23, 2025
| /// <summary> | ||
| /// The collection of headers for the response. | ||
| /// </summary> | ||
| public HeadersCollection Headers { get; set; } |
Contributor
Author
There was a problem hiding this comment.
does it matter if this should be regular set or internal set?
stack-info: PR: #4063, branch: GarrettBeatty/stacked/5
GarrettBeatty
force-pushed
the
GarrettBeatty/stacked/5
branch
from
79996ec to
1efc02d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
Description
This change adds a function to map the GetObjectResponse to TransferUtilityDownloadResponse.
Motivation and Context
Testing
Types of changes
Checklist
License