Generate PutBucket #3928
Open
Generate PutBucket #3928
+1,819
−1,279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dscpinheiro
reviewed
Jul 22, 2025
| @@ -0,0 +1,9 @@ | |||
| { | |||
| "core": { | |||
There was a problem hiding this comment.
Why Core if only S3 files are being changed?
There was a problem hiding this comment.
this is b/c PostMarshallCustomization is generated for every RestXml service and I moved the location of it so that it runs before we set the request.Content
There was a problem hiding this comment.
Got it. Up to you if you'd like to change it now, but you could have that message for Core and have a separate entry for S3 (if someone wanted to check when PutBucket was generated I think it'd make more sense to have that in the specific S3 version).
peterrsongg
force-pushed
the
petesong/generate-s3-phase-2-pr1
branch
from
a1523c2 to
7db86cb
Compare
muhammad-othman
approved these changes
Jul 22, 2025
|
dry run passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Already been reviewed here #3909
Just creating the PR to merge it again
Motivation and Context
Testing
Screenshots (if appropriate)
Types of changes
Checklist
License