Skip to content

Skip unknown properties when mapping EndpointTests V3 #3922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

muhammad-othman
Copy link
Member

Description

Skip unknown properties when mapping EndpointTests

Motivation and Context

This PR change allows the .NET SDKs to ignore unknown properties so the endpoints team can make additive changes and add new endpoint properties without requiring support from the .NET SDK.
This way they can ship the endpoint rules updates and SDKs will benefit from the addition whenever they decide to implement the feature instead of having to wait for all SDKs to schedule and complete the work.

Testing

  • DRY_RUN-22399aa8-3385-40dd-a5d6-663347c06e65
  • Ran the generator using some models that includes unknown endpoint properties.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • I confirm that this pull request can be released under the Apache 2 license

Copy link
Member

@normj normj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but the alternative is how @dscpinheiro made this change into the runtime version of this library in V3 and not add the public skipUnknownProperties and just always skip. 806f777#diff-2a221ac8c2d33c868a08b6d34a568a1ca388d40e03de832776cbb4fcc611dc69

@muhammad-othman
Copy link
Member Author

@normj I wanted to avoid this incase new properties were added and we don't supported yet.
Just allowed EndpointProperties since the SEP mentioned we should allow unknown properties, but for the other parts of the models we probably should fail if we face something we don't recognize.

@muhammad-othman muhammad-othman force-pushed the muhamoth/EndpointTests-skip-unknown-properties-v3 branch from e31efc8 to d56ff54 Compare July 23, 2025 17:13
@dscpinheiro dscpinheiro merged commit edc725d into aws-sdk-net-v3.7-development Jul 23, 2025
3 checks passed
@dscpinheiro dscpinheiro deleted the muhamoth/EndpointTests-skip-unknown-properties-v3 branch July 23, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants