Skip to content

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Aug 28, 2025

Issue

smithy-lang/smithy-typescript#1600

Description

  • use the config body length checker (differs in Node.js and browser) if available for schema serde protocols
  • cleaned up some duplicated code
  • awsQueryCompat support for schema-serde

Testing

CI (unreleased code)

Checklist

  • [n/a] If the PR is a feature, add integration tests (*.integ.spec.ts).
  • [n/a] If you wrote E2E tests, are they resilient to concurrent I/O?
  • If adding new public functions, did you add the @public tag and enable doc generation on the package?

@kuhe kuhe requested a review from a team as a code owner August 28, 2025 16:55
@kuhe kuhe force-pushed the chore/body-len branch 2 times, most recently from 24dbc2d to 19bf7c0 Compare August 28, 2025 17:03
@kuhe kuhe marked this pull request as draft August 28, 2025 18:41
@kuhe kuhe changed the title chore(core/protocols): improve body-len checking and deduplicate shared code chore(core/protocols): improve body-len checking and awsQueryCompat for schema-serde Aug 28, 2025
@kuhe kuhe marked this pull request as ready for review August 28, 2025 19:14
@trivikr trivikr self-requested a review August 28, 2025 19:28
@kuhe kuhe requested review from trivikr and removed request for trivikr August 28, 2025 19:38
@kuhe kuhe merged commit 0cc5678 into aws:main Aug 29, 2025
3 checks passed
@kuhe kuhe deleted the chore/body-len branch August 29, 2025 14:41
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants