fix(middleware-endpoint-discovery): assert clientName and commandName in context
#5232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame` in `context`
syall
force-pushed
the
bang-middleware-endpoint-discovery
branch
from
1b1c2de to
8faf7d1
Compare
syall
changed the title
undefined values in contextclientName and commandName in context
kuhe
approved these changes
Sep 20, 2023
AndrewFossAWS
approved these changes
Sep 20, 2023
trivikr
approved these changes
Sep 20, 2023
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Issue number, if available, prefixed with "#"
N/A.
Description
What does this implement/fix? Explain your changes.
Assert
clientNameandcommandNameincontext, since TypeScript says it can possible beundefinedafter smithy-lang/smithy-typescript#931.Testing
How was this change tested?
N/A.
Additional context
Add any other context about the PR here.
N/A.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.