Skip to content

chore(middleware): replace isFipsRegion checks with useFipsEndpoint config #2988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Nov 4, 2021

Issue

Internal JS-2928

Description

Reads useFipsEndpoint instead of checking for fips in region in middleware.

Testing

Unit testing


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2021

Codecov Report

Merging #2988 (8358c47) into main (af5b00e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2988   +/-   ##
=======================================
  Coverage   58.76%   58.77%           
=======================================
  Files         567      567           
  Lines       30358    30364    +6     
  Branches     7481     7483    +2     
=======================================
+ Hits        17839    17845    +6     
  Misses      12519    12519           
Impacted Files Coverage Δ
packages/middleware-bucket-endpoint/src/index.ts 100.00% <ø> (ø)
...re-bucket-endpoint/src/bucketEndpointMiddleware.ts 93.47% <100.00%> (ø)
...s/middleware-bucket-endpoint/src/bucketHostname.ts 100.00% <100.00%> (ø)
...dleware-bucket-endpoint/src/bucketHostnameUtils.ts 95.95% <100.00%> (-0.12%) ⬇️
.../process-arnables-plugin/parse-outpost-arnables.ts 97.05% <100.00%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af5b00e...8358c47. Read the comment docs.

@trivikr trivikr merged commit d12c98a into aws:main Nov 5, 2021
@trivikr trivikr deleted the replace-isFipsRegion-with-useFipsEndpoint branch November 5, 2021 16:20
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants