-
Notifications
You must be signed in to change notification settings - Fork 621
Closed
Labels
feature-requestNew feature or enhancement. May require GitHub community feedback.New feature or enhancement. May require GitHub community feedback.p2This is a standard priority issueThis is a standard priority issue
Description
Describe the feature
Install size of node_modules increased in v3.565.0
Use Case
At the time of running the test, the latest version of the SDK is v3.568.0
Versions
$ node -v
v20.12.2
$ npm -v
10.5.0
v3.564.0
$ npm init -y && npm install @aws-sdk/[email protected] --save-exact
$ du -sh node_modules
17M node_modules
v3.565.0
$ npm init -y && npm install @aws-sdk/[email protected] --save-exact
$ du -sh node_modules
23M node_modules
v3.568.0
$ npm init -y && npm install @aws-sdk/[email protected] --save-exact
$ du -sh node_modules
17M node_modules
Proposed Solution
The install size increases in v3.565.0
, since npm installs peerDependencies by default and it installs the latest version at the time of running the install in absence of lockfile. In v3.565.0, we switched to using caret for all peerDependencies in #6031 which caused this issue.
To unblock users on package managers which do not install peerDepdendencies by default, like yarn, we added direct dependency of exact client version in #6055. We can similar use exact version of client as a peerDependency in credential providers.
Other Information
No response
Acknowledgements
- I may be able to implement this feature request
- This feature might incur a breaking change
SDK version used
v3.564.0
Environment details (OS name and version, etc.)
Node.js
Metadata
Metadata
Assignees
Labels
feature-requestNew feature or enhancement. May require GitHub community feedback.New feature or enhancement. May require GitHub community feedback.p2This is a standard priority issueThis is a standard priority issue