Add ability to specify directoryTransferMaxConcurrency in S3TransferManager #6329
+288
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anager creation to limit concurrency on download and upload directory to control memory use Signed-off-by: Andre Kurait <[email protected]>
AndreKurait
force-pushed
the
ConfigurableDirectoryTransferMaxConcurrency
branch
from
5581092 to
be0a85b
Compare
Signed-off-by: Andre Kurait <[email protected]>
alextwoods
reviewed
Aug 11, 2025
.../test/java/software/amazon/awssdk/transfer/s3/internal/TransferManagerConfigurationTest.java
Outdated
Show resolved
Hide resolved
…verify maxConncurent downloads is respected Signed-off-by: Andre Kurait <[email protected]>
…alue Signed-off-by: Andre Kurait <[email protected]>
AndreKurait
changed the title
2 tasks
|
2 tasks
AndreKurait
added a commit
to AndreKurait/opensearch-migrations
that referenced
this pull request
Aug 11, 2025
…ncurrent downloads to 10. This requires consuming an update in the aws-sdk aws/aws-sdk-java-v2#6329 Signed-off-by: Andre Kurait <[email protected]>
AndreKurait
added a commit
to AndreKurait/opensearch-migrations
that referenced
this pull request
Aug 11, 2025
…ncurrent downloads to 10. This requires consuming an update in the aws-sdk aws/aws-sdk-java-v2#6329 Signed-off-by: Andre Kurait <[email protected]>
AndreKurait
added a commit
to AndreKurait/opensearch-migrations
that referenced
this pull request
Aug 11, 2025
…ncurrent downloads to 10. This requires consuming an update in the aws-sdk aws/aws-sdk-java-v2#6329 Signed-off-by: Andre Kurait <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Currently there is a hardcoded value for DEFAULT_DIRECTORY_TRANSFER_MAX_CONCURRENCY in TransferConfigurationOption of
100added in #5031. When using the S3TransferManager with limited java heap allocation, this can cause OutOfMemory errors due to number of concurrent file downloads.#6330
Modifications
Updated TransferConfigurationOption to define DirectoryTransferMaxConcurrency and S3TransferManager to use it during upload and download directory with option to specify it in the builder.
Testing
Primary test is the
integrationstyle test in Download/Upload DirectoryHelperTest.While it's difficult to ensure the upper limit is observed without adding arbitrary test time duration to the tests, i've verified locally by modifying the test to use
and observed it timed out after 5 seconds, and with
that it completed very quickly and failed the assertion.
The change makes no behavior change to the default and current behavior
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License