Smoke tests environment improvements #3526
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update run_smoke_tests.py with proper exit codes - Update run-al2-smoke-tests.sh script
sbiscigl
reviewed
Aug 29, 2025
tools/scripts/run_smoke_tests.py
Outdated
| services=should_run_service(services) | ||
| service_ids = os.environ.get('AWS_SMOKE_TEST_SERVICE_IDS', '') | ||
| if not service_ids: | ||
| return 0 |
There was a problem hiding this comment.
i dont think this is what we want to do, this effectively creates a path where if AWS_SMOKE_TEST_SERVICE_IDS is removed for any reason we start ignoring smoke tests. this logic in the most abstract form should become
if (has service id AND service id is a known service in the SDK) {
run _only_ the smoke test for service id
} else {
run all tests
}
the makes it so we never skip smoke tests based on service id logic, we must default to running all tests if we can make sense of service_id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes: Added proper exit codes to the Python script and removed unnecessary parts from the shell script
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.