Skip to content

Conversation

dreambeyondorange
Copy link
Contributor

@dreambeyondorange dreambeyondorange commented Mar 1, 2024

Description of changes

  • Added unit tests to cover this new edge case

Tests

  • Ran unit tests locally

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.78%. Comparing base (ecaffb8) to head (3714a58).

Additional details and impacted files
@@             Coverage Diff              @@
##           release-3.9     #621   +/-   ##
============================================
  Coverage        90.78%   90.78%           
============================================
  Files               20       20           
  Lines             3137     3137           
============================================
  Hits              2848     2848           
  Misses             289      289           
Flag Coverage Δ
unittests 90.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dreambeyondorange dreambeyondorange force-pushed the backing_instance_timeout branch from 15e8359 to 3714a58 Compare March 1, 2024 02:29
@dreambeyondorange dreambeyondorange enabled auto-merge (squash) March 1, 2024 02:32
@dreambeyondorange dreambeyondorange merged commit 21bf5e3 into aws:release-3.9 Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants