Skip to content

miscellaneous clean up #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 13, 2022
Merged

miscellaneous clean up #702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bea2388
remove outdated make target
cjerad Oct 12, 2022
555e42a
remove Dockerfile
cjerad Oct 12, 2022
518670a
fix README formatting
cjerad Oct 12, 2022
21f703b
quote helm chart version
cjerad Oct 12, 2022
69c22c0
update command check in download-ko.sh
cjerad Oct 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 0 additions & 27 deletions Dockerfile
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,12 +108,6 @@ test: delete-test-coverage $(CODECOVERAGE_OUT) ## Run tests.
explore-test-coverage: $(CODECOVERAGE_OUT) ## Display test coverage report in default web browser.
go tool cover -html=$<

##@ Build

.PHONY: run
run: ## Run a controller from your host.
go run ./main.go

##@ Deployment

$(KODATA):
Expand Down
4 changes: 4 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ Your EKS cluster must have an IAM OIDC Provider. Follow the steps in [Create an
Download the service account policy template for AWS CloudFormation at https://github.com/aws/aws-node-termination-handler/releases/download/v2.0.0-alpha/infrastructure.yaml

Then create the IAM Policy by deploying the AWS CloudFormation stack:

```sh
aws cloudformation deploy \
--template-file infrastructure.yaml \
Expand All @@ -50,6 +51,7 @@ aws cloudformation deploy \
Use either the AWS CLI or AWS Console to lookup the ARN of the IAM Policy for the service account.

Create the cluster service account using the following command:

```sh
eksctl create iamserviceaccount \
--cluster <CLUSTER NAME> \
Expand All @@ -64,6 +66,7 @@ eksctl create iamserviceaccount \
### 2. Deploy NTH

Get the ARN of the service account role:

```sh
eksctl get iamserviceaccount \
--cluster <CLUSTER NAME> \
Expand All @@ -72,6 +75,7 @@ eksctl get iamserviceaccount \
```

Add the AWS `eks-charts` helm repository and deploy the chart:

```sh
helm repo add eks https://aws.github.io/eks-charts

Expand Down
2 changes: 1 addition & 1 deletion charts/aws-node-termination-handler-2/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: aws-node-termination-handler-2
description: A Helm chart for aws-node-termination-handler, an open-source component for gracefully handling termination events for node hosted in AWS.
type: application
version: 0.1.0
version: "0.1.0"
appVersion: "2.0.0-0.1"
kubeVersion: ">=1.16-0"
keywords:
Expand Down
2 changes: 1 addition & 1 deletion scripts/download-ko.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ if [[ -z "${dir_path}" ]]; then
exit 1
fi

if ! which wget >/dev/null ; then
if ! command -v wget >/dev/null; then
echo "error: wget not installed" 1>&2
exit 1
fi
Expand Down