Skip to content

Conversation

@cjerad
Copy link
Contributor

@cjerad cjerad commented Apr 15, 2022

Description of changes:

  • Add workflow to run v2's test suite on pushes and PRs to the v2 branch
  • Add ginkgo to the toolchain

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@cjerad cjerad marked this pull request as ready for review April 15, 2022 19:01
@cjerad cjerad requested a review from a team as a code owner April 15, 2022 19:01
@cjerad cjerad requested review from LikithaVemulapalli and brycahta and removed request for a team April 15, 2022 19:01

- name: make test
run: make test
working-directory: ./src
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why set working-directory here? for the deps?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The source code and Makefile are currently in the src sub-directory.

Copy link
Contributor

@brycahta brycahta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@cjerad cjerad merged commit 395ae09 into aws:v2 Apr 18, 2022
@cjerad cjerad deleted the feat-gh-workflow-tests branch April 18, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants