Skip to content

Update go & lib versions in Dockerfiles #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2022
Merged

Update go & lib versions in Dockerfiles #605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7598520
align Dockerfile go versions with app
brycahta Mar 18, 2022
aac3eab
replace go get with go install
brycahta Mar 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/license-test/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
FROM golang:1
FROM golang:1.16

WORKDIR /app

COPY license-config.hcl .
ARG GOPROXY="https://proxy.golang.org,direct"
RUN GO111MODULE=on go get github.com/mitchellh/golicense
RUN GO111MODULE=on go install github.com/mitchellh/golicense@v0.2.0

CMD $GOPATH/bin/golicense
2 changes: 1 addition & 1 deletion test/license-test/gen-license-report.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ mkdir -p $BUILD_DIR
GOBIN=$(go env GOPATH | sed 's+:+/bin+g')/bin
export PATH="$PATH:$GOBIN"

go get github.com/mitchellh/golicense
go install github.com/mitchellh/golicense@v0.2.0
go build -o $BUILD_DIR/nth $SCRIPTPATH/../../.
golicense -out-xlsx=$BUILD_DIR/report.xlsx $SCRIPTPATH/license-config.hcl $BUILD_DIR/nth

4 changes: 2 additions & 2 deletions test/readme-test/spellcheck-Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
FROM golang:1
FROM golang:1.16

RUN go get -u github.com/client9/misspell/cmd/misspell
RUN go install github.com/client9/misspell/cmd/misspell@v0.3.4

CMD [ "/go/bin/misspell" ]
2 changes: 1 addition & 1 deletion test/webhook-test-proxy/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Build the manager binary
FROM golang:1-alpine as builder
FROM golang:1.16-alpine as builder

## GOLANG env
ARG GOPROXY="https://proxy.golang.org|direct"
Expand Down