Fix Helm templates bug which caused duplicate ports key #551 #461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes aws/eks-charts#550 The Helm templates for aws-node-termination-handler will produce invalid DaemonSet(s) and Deployment spec with duplicate ports key if values enableProbesServer and enablePrometheusServer are both set to true.
bwagner5
requested changes
Jun 30, 2021
Contributor
bwagner5
left a comment
bwagner5
left a comment
There was a problem hiding this comment.
Nice! Thanks for the fix! The changes lgtm, but can you change the chart version back to 0.15.1? Our eks-charts automated sync will increment the chart version so that we batch the changes in-between releases. After that, I'll merge it in! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
aws/eks-charts#550
Description of changes
Checklist
README.mdfor modified charts)versioninChart.yamlfor the modified chart(s)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Note, this PR replaces aws/eks-charts#551.