Skip to content

Conversation

@bwagner5
Copy link
Contributor

Issue #, if available:
#417

Description of changes:

  • Change the ClusterRole to a namespace scoped role and move RoleBinding to proper namespace reference.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bwagner5 bwagner5 requested a review from haugenj May 17, 2021 21:58
Copy link
Contributor

@haugenj haugenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bwagner5 bwagner5 merged commit 6f9aa8b into aws:main May 17, 2021
@gabegorelick
Copy link
Contributor

gabegorelick commented May 25, 2021

I'm trying to test that this fixes #417, but it looks like the roleRef in the RoleBinding is wrong. The kind for the resource was changed from ClusterRole to Role, but the RoleBinding wasn't updated:

roleRef: 
  apiGroup: rbac.authorization.k8s.io 
  kind: ClusterRole # should be Role?
  name: {{ template "aws-node-termination-handler.fullname" . }}-psp

EDIT: filed #441 for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants