always do license check and use dockerhub for go-report-card image pulls #432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brycahta
reviewed
May 13, 2021
| RUN go get -u golang.org/x/tools/cmd/goimports | ||
|
|
||
| CMD $GOPATH/bin/goreportcard-cli -v -t 90 | ||
| CMD $GOPATH/bin/goreportcard-cli -v -t 90 |
There was a problem hiding this comment.
does this threshold not mean anything/can it be removed? It's set to 93 in the script itself and it seems to adhere to that than this param
There was a problem hiding this comment.
it's the default threshold if you don't specify any command when calling docker run.
brycahta
approved these changes
May 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.