Skip to content

Impl SSL_client_hello_get1_extensions_present and friends #2561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Jul 21, 2025

Description of changes:

Implementation and documentation for:

  • SSL_client_hello_get1_extensions_present
  • SSL_client_hello_get_extension_order
  • SSL_client_hello_get0_legacy_version

Testing:

Added new tests for coverage.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner July 21, 2025 15:27
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2025

Codecov Report

❌ Patch coverage is 82.08955% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.68%. Comparing base (aea8013) to head (4e95542).

Files with missing lines Patch % Lines
ssl/ssl_client_hello_test.cc 84.21% 11 Missing and 1 partial ⚠️
ssl/ssl_lib.cc 79.31% 12 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2561    +/-   ##
========================================
  Coverage   78.68%   78.68%            
========================================
  Files         645      645            
  Lines      110738   110872   +134     
  Branches    15657    15672    +15     
========================================
+ Hits        87130    87243   +113     
- Misses      22919    22940    +21     
  Partials      689      689            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@justsmth justsmth force-pushed the SSL_client_hello_get1_extensions_present branch from 3cde580 to 0ebf371 Compare July 22, 2025 13:35
@justsmth justsmth changed the title Impl SSL_client_hello_get1_extensions_present and SSL_client_hello_get_extension_order Impl SSL_client_hello_get1_extensions_present and friends Jul 22, 2025
@justsmth justsmth force-pushed the SSL_client_hello_get1_extensions_present branch from 4326849 to 9d485c1 Compare July 22, 2025 14:28
@justsmth justsmth force-pushed the SSL_client_hello_get1_extensions_present branch from 9d485c1 to 4e95542 Compare July 31, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants