Hmac sha implementation #2557
Open
Hmac sha implementation #2557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add LIEF version 0.13.0 as git submodule - Configure CMake to build LIEF from source - Update inject_hash implementation to use LIEF - Remove pre-built LIEF binaries - Add initial C++ implementation and tests This change improves portability and maintainability by using LIEF as a submodule instead of pre-built binaries.
- Add GitHub Actions workflow for Ubuntu and macOS - Add test script with detailed logging - Handle OS-specific library names - Add environment verification - Disable fail-fast to test both environments
- Adds flag to fetch C/C++ libraries
- Added fips_hashing implementation - Updated CMake configuration - Modified inject_hash_cpp to use fips_hashing - Removed test_sha256.cpp
- Created a new file called fips_hashing.c which has all the files on which HMAC and SHA are dependent on - Modified a few dependencies so that the dependency chain gets limited - inject_hash.cpp can now finally implement HMAC my simply including it into the script.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -183,10 +183,6 @@ DEFINE_METHOD_FUNCTION(EVP_PKEY_METHOD, EVP_PKEY_hmac_pkey_meth) { | |||
| out->ctrl_str = hmac_ctrl_str; | |||
There was a problem hiding this comment.
warning: use of undeclared identifier 'out' [clang-diagnostic-error]
out->ctrl_str = hmac_ctrl_str;
^| @@ -0,0 +1,63 @@ | |||
| #include <LIEF/LIEF.hpp> | |||
There was a problem hiding this comment.
warning: 'LIEF/LIEF.hpp' file not found [clang-diagnostic-error]
#include <LIEF/LIEF.hpp>
^| } | ||
| std::vector<uint8_t> calculate_hash(HMAC_size(&ctx)); | ||
|
|
||
| unsigned int calculate_hash_len; |
There was a problem hiding this comment.
warning: variable 'calculate_hash_len' is not initialized [cppcoreguidelines-init-variables]
Suggested change
| unsigned int calculate_hash_len; | |
| unsigned int calculate_hash_len = 0; |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## inject-hash-cpp-experiment #2557 +/- ##
==============================================================
- Coverage 78.90% 78.75% -0.15%
==============================================================
Files 640 642 +2
Lines 109766 110241 +475
Branches 15526 15604 +78
==============================================================
+ Hits 86612 86824 +212
- Misses 22457 22719 +262
- Partials 697 698 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration of HMAC and SHA functionalities from the crypto submodule.