Fix python main diff after upstream PR 135402 merge #2542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torben-hansen
approved these changes
Jul 14, 2025
|
Why not just delete the patch outright? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2542 +/- ##
==========================================
- Coverage 78.70% 78.69% -0.01%
==========================================
Files 644 644
Lines 110503 110503
Branches 15643 15643
==========================================
- Hits 86969 86958 -11
- Misses 22837 22845 +8
- Partials 697 700 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
smittals2
approved these changes
Jul 14, 2025
justsmth
approved these changes
Jul 15, 2025
@darylmartin100 -- The remaining patch file just configures static linkage of AWS-LC to CPython. Here's a PR to dynamically link AWS-LC when testing against CPython's main, matching our upstream CI job in CPython's repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
n/a
Description of changes:
Updating our python main CI patch now that upstream PR 135402 has been merged.
Call-outs:
n/a
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.