Tidy up changes added with PR#115 and limit it to only work with Python3.12 in Lambda. #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-pewpew
reviewed
Oct 27, 2023
alex-pewpew
reviewed
Oct 27, 2023
alex-pewpew
reviewed
Oct 27, 2023
| # which can then process signals. | ||
| if self.use_thread_for_polling_next: | ||
| try: | ||
| from concurrent.futures import ThreadPoolExecutor |
There was a problem hiding this comment.
I'm ok with keeping it here and not in constructor. Performance overhead is negligible, maybe if one day we refactor LambdaRuntimeClient() class, we will revisit the location of lazy imports
Thank you for addressing the comments
alex-pewpew
approved these changes
Oct 27, 2023
briensea
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Target (OCI, Managed Runtime, both): OCI and Managed Runtime
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.