Skip to content

Include GitHub action on push and pr #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 3, 2020
Merged

Include GitHub action on push and pr #1

merged 2 commits into from
Dec 3, 2020

Conversation

stefanbotez
Copy link
Contributor

Description of changes:

  • Added GitHub workflow to run the required checks on push and pr
  • Added build prerequisite target to pr target
  • Removed unnecessary -it option from codebuild_build.sh because it was causing tty error when running the GitHub action
  • Refactored postinstall script to only clean up the uncompressed dependencies

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

carlzogh
carlzogh reviewed Dec 2, 2020
View reviewed changes
edhzsz
edhzsz approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@edhzsz edhzsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carlzogh carlzogh merged commit a896c51 into aws:main Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@edhzsz edhzsz edhzsz approved these changes

@carlzogh carlzogh carlzogh approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefanbotez @edhzsz @carlzogh