Skip to content

Remove asserts from static functions #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2024
Merged

Remove asserts from static functions #28

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bfedbc
Remove asserts from static functions
kar-rahul-aws May 27, 2024
cf8702c
Merge branch 'main' into update_code_coverage
kar-rahul-aws May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions source/MQTTFileDownloader_base64.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,9 +191,6 @@ static Base64Status_t preprocessBase64Index( uint8_t base64Index,
int64_t numPaddingVal;
int64_t numWhitespaceVal;

assert( numPadding != NULL );
assert( numWhitespace != NULL );

numPaddingVal = *numPadding;
numWhitespaceVal = *numWhitespace;

Expand Down Expand Up @@ -263,8 +260,6 @@ static void updateBase64DecodingBuffer( const uint8_t base64Index,
uint32_t base64IndexBuffer;
uint32_t numDataInBuffer;

assert( base64IndexBufferPtr != NULL );
assert( numDataIndexBuffer != NULL );
assert( base64Index <= SYMBOL_TO_INDEX_MAP_VALUE_UPPER_BOUND );

base64IndexBuffer = *base64IndexBufferPtr;
Expand Down Expand Up @@ -322,12 +317,8 @@ static Base64Status_t decodeBase64IndexBuffer( uint32_t * base64IndexBufferPtr,
uint32_t numDataInBuffer;
uint32_t numDataToWrite;

assert( base64IndexBufferPtr != NULL );
assert( numDataIndexBuffer != NULL );
assert( ( *numDataIndexBuffer == 2U ) || ( *numDataIndexBuffer == 3U ) ||
( *numDataIndexBuffer == 4U ) );
assert( dest != NULL );
assert( outputLength != NULL );

outputLen = *outputLength;
base64IndexBuffer = *base64IndexBufferPtr;
Expand Down