chore: check for cached token and exception type before retrying #902
+71
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuanLeee
commented
Jun 13, 2025
| token_info = FederatedAuthPlugin._token_cache.get(cache_key) | ||
|
|
||
| if token_info is not None and not token_info.is_expired(): | ||
| is_cached_token = token_info is not None and not token_info.is_expired() |
There was a problem hiding this comment.
Similar logic to JDBC wrapper
JuanLeee
commented
Jun 13, 2025
| assert WrapperProperties.PASSWORD.get(test_props) == _TEST_TOKEN | ||
|
|
||
| @patch("aws_advanced_python_wrapper.federated_plugin.FederatedAuthPlugin._token_cache", _token_cache) | ||
| def test_no_cached_token_raises_exception(mocker, mock_plugin_service, mock_session, mock_func, mock_client, mock_dialect, |
There was a problem hiding this comment.
Didn't see any unit tests associated with the JDBC wrapper so not sure if this is appropriate.
karenc-bq
reviewed
Jun 13, 2025
karenc-bq
reviewed
Jun 13, 2025
karenc-bq
reviewed
Jun 13, 2025
karenc-bq
reviewed
Jun 13, 2025
JuanLeee
force-pushed
the
auth/checkToken
branch
3 times, most recently
from
250f93f to
61b4d00
Compare
JuanLeee
force-pushed
the
auth/checkToken
branch
from
61b4d00 to
f1106d1
Compare
karenc-bq
approved these changes
Jun 19, 2025
karenc-bq
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The auth plugins should only retry connection attempts with a new token if the initial attempt failed due to expired token from the cache.
Need to port over this fix from JDBC: aws/aws-advanced-jdbc-wrapper#1430
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.