fix: support both types of cn endpoint patterns #701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karenc-bq
force-pushed
the
fix/china-endpoints
branch
2 times, most recently
from
2b29296 to
e4f53d7
Compare
aaron-congo
reviewed
Oct 10, 2024
|
|
||
| @staticmethod | ||
| def clear_cache(): | ||
| RdsUtils.CACHE_PATTERNS.clear() |
There was a problem hiding this comment.
Do we want to clear CACHED_DNS_PATTERNS too?
karenc-bq
force-pushed
the
fix/china-endpoints
branch
from
adb35ff to
9352b4c
Compare
sergiyvamz
reviewed
Oct 15, 2024
karenc-bq
force-pushed
the
fix/china-endpoints
branch
from
ff47fd8 to
34dbd16
Compare
sergiyvamz
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #700
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.