fix: small fixes & docs sagemaker studio #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athewsey
reviewed
Aug 6, 2025
| "outputs": [], | ||
| "source": [ | ||
| "use_local_mode = True # Set to true to run on local instance\n", | ||
| "use_local_mode = False # Set to true to run on local instance\n", |
There was a problem hiding this comment.
Just wanted to check, this is an intentional change to the default behaviour - not an accidental check-in, right?
athewsey
reviewed
Aug 6, 2025
Comment on lines
-625
to
+662
| " # use_spot_instances=True, # Cost efficient inference. Inference can be restarted if no spot capacity. \n", | ||
| " # use_spot_instances=True, # Enable cost efficient inference. Inference can be restarted if no spot capacity. \n", |
There was a problem hiding this comment.
It's not a problem, but I wonder if there was a particular reason we have spot enabled by default in training but disabled by default in inference?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #3
Description of changes:
sagemakerfor streamlined IAM #3By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.