Skip to content

Conversation

@arvy-p
Copy link

@arvy-p arvy-p commented Mar 10, 2022

Issue #, if available:

Description of changes:
I have updated Dockerfile with RUN commands to have git installed

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@arvy-p arvy-p closed this Mar 10, 2022
@arvy-p arvy-p reopened this Mar 10, 2022
@fjpa121197
Copy link

fjpa121197 commented Mar 14, 2022

One question regarding this.

Should git be installed before the following command?

RUN pip install papermill jupyter nteract-scrapbook boto3 requests && pip install -r /tmp/requirements.txt

In case there are git commands in requirements.txt

@tomfaulhaber
Copy link
Contributor

Sorry, I'm getting to this late.

What is the motivation for having git in the default container? Is it a requirement for a common use case here? At container build time or container run time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants