refactor(parameters): replace EnvironmentVariablesService class with helper functions in Parameters #4168
Conversation
…helper functions in Parameters
boring-cyborg
bot
added
commons
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Thanks for picking this up, it's looking good! I only had one small comment. |
…r.ts Removed test utilities that remained from Environment Variables Service Changes to be committed: modified: packages/commons/src/envUtils.ts modified: packages/commons/tests/unit/envUtils.test.ts modified: packages/parameters/src/base/GetOptions.ts modified: packages/parameters/src/ssm/SSMProvider.ts deleted: packages/parameters/src/types/ConfigServiceInterface.ts deleted: packages/parameters/src/utils/env.ts modified: packages/parameters/tests/unit/BaseProvider.test.ts
|
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
|
Thank you for this PR @JonkaSusaki, it's now been merged! |
|
Thanks guys! I would love to keep contributing to this project! Next week I'll look for some other issues since I won't be able to work this week. Keep up the good work! |
Summary
Changes
This PR removes the legacy class-based EnvironmentVariablesService from the Parameters package and replaces it with functional local helpers.
packages/parameters/src/config/EnvironmentVariablesService.tsfile.packages/parameters/tests/unit/EnvironmentVariablesService.test.tsfile, since our tests are backed bycommons/tests/unit/envUtils.test.ts.packages/parameters/src/utils/env.tsfile containing the helpers.packages/parameters/src/base/BaseProvider.ts.packages/parameters/src/base/GetMultipleOptions.ts.packages/parameters/src/base/GetOptions.ts.packages/parameters/src/appconfig/AppConfigProvider.ts.isValueTruefunction to thepackages/commons/src/envUtils.tsbecause it is needed inpackages/parameters/src/ssm/SSMProvider.ts.isValueTrueinpackages/commons/tests/unit/envUtils.test.ts.packages/parameters/src/ssm/SSMProvider.ts.Issue number: #4138
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.