Skip to content

Conversation

@dreamorosi
Copy link
Contributor

Description of your changes

This PR introduces the Parser component to the JMESPath utility.

The parser is the main orchestrator component and uses a lexer (#2205), AST (#2210), and tree interpreter (#2209) to tokenize, abstract, and traverse the JMESPath expression and produce a result.

Related issues, RFCs

Issue number: #2211

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Mar 21, 2024
@dreamorosi dreamorosi requested a review from a team March 21, 2024 16:27
@dreamorosi dreamorosi requested a review from a team as a code owner March 21, 2024 16:27
@pull-request-size pull-request-size bot added the size/XL PRs between 500-999 LOC, often PRs that grown with feedback label Mar 21, 2024
@github-actions github-actions bot added the feature PRs that introduce new features or minor changes label Mar 21, 2024
@dreamorosi dreamorosi linked an issue Mar 21, 2024 that may be closed by this pull request
2 tasks
@dreamorosi dreamorosi force-pushed the feat/jmespath_parser branch from d340d50 to c72a4f7 Compare March 25, 2024 10:16
@pull-request-size pull-request-size bot added size/XXL PRs with 1K+ LOC, largely documentation related and removed size/XL PRs between 500-999 LOC, often PRs that grown with feedback labels Mar 25, 2024
@dreamorosi
Copy link
Contributor Author

The tests that will cover this and all other JMESPath PRs are in this PR: #2271

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sthulb sthulb merged commit 2ee6f12 into main Mar 27, 2024
@sthulb sthulb deleted the feat/jmespath_parser branch March 27, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature PRs that introduce new features or minor changes size/XXL PRs with 1K+ LOC, largely documentation related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: JMESPath parser

2 participants