-
Notifications
You must be signed in to change notification settings - Fork 92
feat: SQS Partial batch Utility #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msailes
reviewed
Oct 3, 2020
powertools-sqs/src/main/java/software/amazon/lambda/powertools/sqs/PowertoolsSqs.java
Outdated
Show resolved
Hide resolved
a490adc
to
2bf4d6d
Compare
2bf4d6d
to
4edaf61
Compare
6f42c63
to
7cce85f
Compare
0cb9cfc
to
33eb76d
Compare
msailes
reviewed
Oct 5, 2020
msailes
reviewed
Oct 5, 2020
msailes
reviewed
Oct 5, 2020
msailes
reviewed
Oct 5, 2020
msailes
reviewed
Oct 5, 2020
msailes
reviewed
Oct 5, 2020
msailes
reviewed
Oct 5, 2020
msailes
reviewed
Oct 5, 2020
msailes
reviewed
Oct 5, 2020
example/HelloWorldFunction/src/main/java/helloworld/AppSqsEventUtil.java
Show resolved
Hide resolved
msailes
reviewed
Oct 5, 2020
powertools-sqs/src/main/java/software/amazon/lambda/powertools/sqs/PowertoolsSqs.java
Outdated
Show resolved
Hide resolved
msailes
reviewed
Oct 5, 2020
powertools-sqs/src/main/java/software/amazon/lambda/powertools/sqs/PowertoolsSqs.java
Outdated
Show resolved
Hide resolved
msailes
reviewed
Oct 5, 2020
powertools-sqs/src/main/java/software/amazon/lambda/powertools/sqs/internal/BatchContext.java
Show resolved
Hide resolved
msailes
reviewed
Oct 5, 2020
...sqs/src/test/java/software/amazon/lambda/powertools/sqs/PowertoolsSqsBatchProcessorTest.java
Show resolved
Hide resolved
msailes
reviewed
Oct 5, 2020
.../java/software/amazon/lambda/powertools/sqs/internal/SqsMessageBatchProcessorAspectTest.java
Outdated
Show resolved
Hide resolved
89851a0
to
5835440
Compare
msailes
approved these changes
Oct 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
jeromevdl
pushed a commit
to jeromevdl/aws-lambda-powertools-java
that referenced
this pull request
Oct 19, 2020
* Initial API skeleton for Partial SQS batch util * Better error handling * Initial Test cases setup and some refactorings * Full Test cases coverage * Rename API method for batch processing * java docs * public docs update * Fix correct place holder for queuename and account * Example usage with relevant permissions * Minor doc updates * Ranme method to set custom sqs client * Make test less confusing Co-authored-by: Pankaj Agrawal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Closes #119
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.