chore: Console output overrides lambda console out #936
+291
−142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #932
Summary
Changes
This pull request refactors the
ConsoleWrapper
class to improve its handling of console output in AWS Lambda environments and enhance testability. It introduces new methods for determining and overriding console output, removes deprecated logic, and updates the test suite to ensure comprehensive coverage of the changes.Refactoring of
ConsoleWrapper
:_outputResetPerformed
flag and replacedEnsureConsoleOutputOnce
withEnsureConsoleOutput
, which uses the newShouldOverrideConsole
method to decide when to override console output. [1] [2] [3] [4]ShouldOverrideConsole
andHasLambdaReInterceptedConsole
methods to improve the detection of whether console output should be overridden in Lambda environments.OverrideLambdaLogger
to prevent crashes if console override fails.Test Suite Enhancements:
ConsoleWrapperTests
to include setup and teardown logic for isolating test state, ensuring reliable test execution._outputResetPerformed
and replaced them with updated tests for the new logic.Code Cleanup:
errordOutput
toerrorOutput
) and improved code readability.ClearOutputResetFlag
method but retained it for backward compatibility, ensuring it does not throw errors. [1] [2]User experience
Checklist
Please leave checklist items unchecked if they do not apply to your change.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.