Skip to content

non-strict deserializer for request data #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 25, 2020
Merged

non-strict deserializer for request data #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2db3a32
non-strict deserializer for request data
ammokhov Nov 24, 2020
79ba104
restart
ammokhov Nov 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/cloudformation_cli_python_lib/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,12 @@ class RequestData:
previousStackTags: Optional[Mapping[str, Any]] = None
previousSystemTags: Optional[Mapping[str, Any]] = None

def __init__(self, **kwargs: Any) -> None:
dataclass_fields = {f.name for f in fields(self)}
for k, v in kwargs.items():
if k in dataclass_fields:
setattr(self, k, v)

@classmethod
def deserialize(cls, json_data: MutableMapping[str, Any]) -> "RequestData":
req_data = RequestData(**json_data)
Expand Down
10 changes: 8 additions & 2 deletions tests/lib/utils_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,18 +78,24 @@ def test_handler_request_serde_roundtrip():
"previousResourceProperties": None,
"stackTags": {"tag1": "abc"},
"previousStackTags": {"tag1": "def"},
"undesiredField": "value",
},
"stackId": "arn:aws:cloudformation:us-east-1:123456789012:stack/SampleStack/e72"
"2ae60-fe62-11e8-9a0e-0ae8cc519968",
}
undesired = "undesiredField"
ser = HandlerRequest.deserialize(payload).serialize()
# remove None values from payload
expected = {
k: {k: v for k, v in payload["requestData"].items() if v is not None}
k: {
k: v
for k, v in payload["requestData"].items()
if v is not None and k not in undesired
}
if k == "requestData"
else v
for k, v in payload.items()
if v is not None
if v is not None and k not in undesired
}

assert ser == expected
Expand Down