Skip to content

Conversation

rjlohan
Copy link
Contributor

@rjlohan rjlohan commented Nov 16, 2018

Created CloudFormation templates, and an example script (which can be removed later) showing how to standup the stack and run a test invocation.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rjlohan rjlohan added the enhancement New feature or request label Nov 16, 2018
@rjlohan rjlohan force-pushed the initial-lambda-wrapper-3 branch 2 times, most recently from 769b615 to c01687a Compare November 19, 2018 19:43
@rjlohan rjlohan force-pushed the initial-lambda-wrapper-3 branch from c01687a to 61719a0 Compare November 19, 2018 20:15
Copy link
Contributor

@tobywf tobywf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the script isn't needed, prefer if we didn't check in or spend time reviewing it. otherwise, need to at least run ShellCheck over it.

Parameters:
ResourceType:
Type: String
AllowedPattern: "^[a-zA-Z0-9]{2,64}-[a-zA-Z0-9]{2,64}-[a-zA-Z0-9]{2,64}$"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk if having validation here is useful, it's just another place to get out of sync

@tobywf tobywf merged commit 289c96d into master Nov 20, 2018
@tobywf tobywf deleted the initial-lambda-wrapper-3 branch November 20, 2018 20:09
brianlaoaws added a commit to brianlaoaws/cloudformation-cli-java-plugin that referenced this pull request Nov 25, 2024
…brianlao-github-fort

Fix resource targetting for a stack level hook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants