Fix IdentifierUtils unit tests #442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prerna-p
approved these changes
Sep 3, 2024
zhaomicx
approved these changes
Sep 3, 2024
agarikana
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes: We were checking a randomly generated string against a hardcoded value, so I changed it to test against the expected pattern instead. This is not used directly inside this repo at any point. This is a tool that can be used by downstream users, to generate user friendly resource names for named resources whenever the customer doesn't pass in an explicit name. It's supposed to be used in create scenarios to create a resource name when that's missing, so we shouldn't need the id to be consistently generated in value, only in format.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.