Add getPreviousResourceTags method #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description of changes: This change adds getPreviousResourceTags method which returns previous tags that were applied to a resource.
The tags come from previousStackTags and previousResourceDefinedTags
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
|
LGTM. Let's verify this change with one of the resources e.g. R53 HostedZone. Once we confirm it works (Update handler can get the previousResourceTags), will approve it. |
wbingli
suggested changes
Aug 20, 2020
|
|
||
| if (request != null && request.getRequestData() != null) { | ||
| replaceInMap(previousResourceTags, request.getRequestData().getPreviousStackTags()); | ||
| replaceInMap(previousResourceTags, |
There was a problem hiding this comment.
The getPreviousResourceProperties() is null for CREATE/DELETE/READ, and not all provideResourceDefinedTags handles the null resource model. let's have a null check here.
if (request.getRequestData().getPreviousResourceProperties() != null) {
replaceInMap(previousResourceTags,provideResourceDefinedTags(request.getRequestData().getPreviousResourceProperties()));
}
xiwhuang
approved these changes
Aug 20, 2020
wbingli
suggested changes
Aug 20, 2020
wbingli
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #292
Description of changes: This change adds getPreviousResourceTags method which returns previous tags that were applied to a resource. The tags come from previousStackTags and previousResourceDefinedTags
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.