Removed account ID from metric namespace #293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbingli
approved these changes
Jul 29, 2020
nina-ctrlv
approved these changes
Jul 29, 2020
|
When I ran pre-commit run --all-files everything passed, although beforehand I hand to run |
This was referenced Jul 30, 2020
|
Build failures are now fixed with new pytest release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The removed account ID is the customer account ID instead of the provider account ID. This means that for public types, a new metric namespace would be created each time we need to emit metrics. The main issue with this is that the internal and logging failure alarms will not work properly and service teams may not be notified of issues.
Go plugin PR: aws-cloudformation/cloudformation-cli-go-plugin#151
Python plugin PR: aws-cloudformation/cloudformation-cli-python-plugin#108
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.