-
Notifications
You must be signed in to change notification settings - Fork 48
added aws-guided codegen model #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
please update the name of this PR |
can you please post the results of a sample code generation? |
python/rpdk/java/templates/init/guided_aws/StubCreateHandler.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please include a lengthy description of what testing you have done on this and include links to samples
python/rpdk/java/templates/init/guided_aws/StubCreateHandler.java
Outdated
Show resolved
Hide resolved
python/rpdk/java/templates/init/guided_aws/StubCreateHandler.java
Outdated
Show resolved
Hide resolved
python/rpdk/java/templates/init/guided_aws/StubDeleteHandler.java
Outdated
Show resolved
Hide resolved
python/rpdk/java/templates/init/guided_aws/StubDeleteHandler.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good just some duplication in tests and a few open questions about some of the codegen changes below
python/rpdk/java/templates/init/guided_aws/StubCreateHandler.java
Outdated
Show resolved
Hide resolved
python/rpdk/java/templates/init/guided_aws/StubCreateHandler.java
Outdated
Show resolved
Hide resolved
python/rpdk/java/templates/init/guided_aws/StubListHandler.java
Outdated
Show resolved
Hide resolved
python/rpdk/java/templates/init/guided_aws/StubCreateHandler.java
Outdated
Show resolved
Hide resolved
python/rpdk/java/templates/init/guided_aws/StubCreateHandler.java
Outdated
Show resolved
Hide resolved
python/rpdk/java/templates/init/guided_aws/StubCreateHandler.java
Outdated
Show resolved
Hide resolved
python/rpdk/java/templates/init/guided_aws/StubCreateHandler.java
Outdated
Show resolved
Hide resolved
python/rpdk/java/templates/init/guided_aws/StubCreateHandler.java
Outdated
Show resolved
Hide resolved
python/rpdk/java/templates/init/guided_aws/StubUpdateHandler.java
Outdated
Show resolved
Hide resolved
python/rpdk/java/templates/init/guided_aws/StubDeleteHandler.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with most of the comments from @aygold92 we can make some more updates here.
python/rpdk/java/templates/init/guided_aws/StubCreateHandler.java
Outdated
Show resolved
Hide resolved
python/rpdk/java/templates/init/guided_aws/StubCreateHandler.java
Outdated
Show resolved
Hide resolved
python/rpdk/java/templates/init/guided_aws/StubCreateHandler.java
Outdated
Show resolved
Hide resolved
python/rpdk/java/templates/init/guided_aws/StubDeleteHandler.java
Outdated
Show resolved
Hide resolved
python/rpdk/java/templates/init/guided_aws/StubDeleteHandler.java
Outdated
Show resolved
Hide resolved
python/rpdk/java/templates/init/guided_aws/StubDeleteHandler.java
Outdated
Show resolved
Hide resolved
python/rpdk/java/templates/init/guided_aws/StubDeleteHandler.java
Outdated
Show resolved
Hide resolved
python/rpdk/java/templates/init/guided_aws/StubDeleteHandler.java
Outdated
Show resolved
Hide resolved
python/rpdk/java/templates/init/guided_aws/StubDeleteHandler.java
Outdated
Show resolved
Hide resolved
python/rpdk/java/templates/init/guided_aws/StubDeleteHandler.java
Outdated
Show resolved
Hide resolved
python/rpdk/java/templates/init/guided_aws/StubCreateHandler.java
Outdated
Show resolved
Hide resolved
python/rpdk/java/templates/init/guided_aws/StubUpdateHandler.java
Outdated
Show resolved
Hide resolved
python/rpdk/java/templates/init/guided_aws/StubUpdateHandler.java
Outdated
Show resolved
Hide resolved
python/rpdk/java/templates/init/guided_aws/StubUpdateHandler.java
Outdated
Show resolved
Hide resolved
python/rpdk/java/templates/init/guided_aws/StubDeleteHandler.java
Outdated
Show resolved
Hide resolved
python/rpdk/java/templates/init/guided_aws/StubCreateHandler.java
Outdated
Show resolved
Hide resolved
python/rpdk/java/templates/init/guided_aws/StubUpdateHandler.java
Outdated
Show resolved
Hide resolved
python/rpdk/java/templates/init/guided_aws/StubUpdateHandler.java
Outdated
Show resolved
Hide resolved
python/rpdk/java/templates/init/guided_aws/StubUpdateHandler.java
Outdated
Show resolved
Hide resolved
python/rpdk/java/templates/init/guided_aws/StubCreateHandler.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments and also need a backfill the recent POJO fix.
LGTM. But keep an eye on the POJO.java for a recent fix |
Issue #, if available:
Description of changes:
along with @rjlohan refactored codegen model to allow
aws guided
option. This option generates resource handlers (each handler has a special stub) and supporting files allowing developer to use functional paradigm.refactored files:
BaseHandlerStd
- abstract class that has ahandleRequst
wrapperCreateHandler
- has a sample create handler context patternDeleteHandler
- has a sample delete handler context patternReadHandler
- has a sample read handler context patternUpdateHandler
- has a sample update handler context patternClientBuilder
- has a sample sdkClient builderTranslator
- has sample api requestsHaving progress chain pattern pre-generated for developers gives less function state control, less worry of exception handling, and more standardized approach for any future custom resource implementations.
mvn verify
builds successfully:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.