Add new integration tests for newly added one off task #594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amazreech
requested changes
Jul 30, 2024
Contributor
amazreech
left a comment
amazreech
left a comment
There was a problem hiding this comment.
Blocking Automatic Merging, waiting for additional approvals.
omkhegde
requested changes
Jul 31, 2024
Contributor
|
I believe |
amazreech
reviewed
Jul 31, 2024
amazreech
reviewed
Jul 31, 2024
Contributor
amazreech
left a comment
amazreech
left a comment
There was a problem hiding this comment.
Looks good to me for the most part. Few things to improve could be:
- renaming step names on both
.github/workflow/test-workflow.ymlfile and thetest-workflow.ymlfile. - Adding a PR description about what the new
task-definition-run-task.jsondoes.
amazreech
approved these changes
Jul 31, 2024
omkhegde
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #54 and #304 and #273
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.