Replace lodash with local utils #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this module contains all the helpers that lodash was being used for, except for reduce
and remove lodash, since it's not being used anywhere else now
|
@w33ble nice! Would be great to add tests and I'm happy to merge it. |
it's still being used in the tests
pulled form lodash, required for functional parity
|
Added some basic tests for the utils. I also made |
|
@w33ble It looks pretty good. Thanks a lot for your time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24
Alternative to #28
Lodash wasn't being used too heavily, so instead of leaning on babel-plugin-lodash, it was pretty easy to replace it outright. This PR adds a small
utils.jsfile with helpers that perform the same functionality lodash was being used for, in 42 lines.The only exception is
_.reduce, which I replaced withjust-reduce-object, a quite small and dependency-free library that functions the same way (with a small change in the signature of the iteratee).Existing tests still pass locally, and I'd be willing to add tests for the code in
utils.jsif you'd like as well.