fix: DPoP nonce retry on auth code callback #2391
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The auth code callback flow was missing the DPoP nonce retry pattern that already exists for:
refreshTokenGrantRequest)genericTokenEndpointRequest)When a server requires a DPoP nonce, it responds with HTTP 400 +
use_dpop_nonceerror +DPoP-Nonceheader. The client must retry with the provided nonce. Without this retry logic, the error propagates to the user and login fails.endpoint flows.
Changes
Wrapped the
authorizationCodeGrantRequestCallwithwithDPoPNonceRetry()when DPoP is enabled, matching the existing patterns for other token.src/server/auth-client.ts(lines 784-789): Added conditional DPoP nonce retry wrapper inhandleCallback()methodsrc/server/dpop-authcode-nonce-retry.test.ts: Added MSW-based HTTP flow tests validating:dpopUtils.ts: handle both type of request retriesReferences
Addendum
Replaces #2390 with all review comments addressed