Skip to content

Conversation

@tusharpandey13
Copy link
Contributor

@tusharpandey13 tusharpandey13 commented Oct 29, 2025

Fixes #2340

Use Headers.append() instead of Headers.set()

See Headers: append() method

@tusharpandey13 tusharpandey13 requested a review from a team as a code owner October 29, 2025 13:40
@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.61%. Comparing base (df1725e) to head (b67390c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2386   +/-   ##
=======================================
  Coverage   87.61%   87.61%           
=======================================
  Files          37       37           
  Lines        4086     4086           
  Branches      809      809           
=======================================
  Hits         3580     3580           
  Misses        503      503           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tusharpandey13
Copy link
Contributor Author

@claude please review this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2025

Claude finished @tusharpandey13's task —— View job


PR Review Complete

Overall Assessment

✅ This PR correctly fixes a critical bug where set-cookie headers were being overwritten instead of preserved. The change from Headers.set() to Headers.append() is the appropriate solution for handling multi-value headers like set-cookie. The code quality is excellent with clear documentation explaining the rationale, and the fix aligns with HTTP standards for header handling.


Job run | Branch: bugfix/sample-copy-cookie-headers

@tusharpandey13 tusharpandey13 merged commit a40d31b into main Oct 30, 2025
9 checks passed
@tusharpandey13 tusharpandey13 deleted the bugfix/sample-copy-cookie-headers branch October 30, 2025 05:43
This was referenced Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sample application does not copy cookie headers from Auth0 response to Intl response correctly

4 participants